Fix "unconfigured TLS" panic in db::oneoff_async_connection() fn
#9674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9674 +/- ##
=======================================
Coverage 88.71% 88.71%
=======================================
Files 287 287
Lines 29339 29339
=======================================
Hits 26028 26028
Misses 3311 3311 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enqueue-jobadmin tool has been silently failing on our staging environment since #9632 was merged. This PR fixes it by reusing ourestablish_async_connection()fn, which sets up the TLS configuration correctly.It is a bit unforunate that this wasn't caught earlier though. We could potentially look into using TLS for the database connection on CI, but we'd also need to write tests for all of the admin tools (which we should do anyway...).
It is also a bit surprising that the Heroku Scheduler, which regularly uses this admin tool to enqueue regular tasks, didn't report any warnings about the tool crashing all the time, but I guess there is not much we can do on that front :-/